Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linting issues #33

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Fix Linting issues #33

merged 4 commits into from
Jul 29, 2024

Conversation

mboyamike
Copy link
Contributor

Description

This is a code refactor to fix lint issues caused by the new linter.
It should fix #26

Most of the issues relate to line length and explicit types.
Added only one ignore for the throwing explicit types. the dio exceptions
class implements exception but the lint specifies extending exceptions.
I did not see a straightforward way of extending without changing the
behaviour of the class.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link
Contributor

@MillerAdulu MillerAdulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested then it's ready to merge.

In addition, please enable the following lines:

.github/workflows/pr-check.yml:36-37
.github/workflows/main.yml:36-37

This should ensure every piece of code passes analysis before it can be merged.

lib/common/network/api_helper.dart Outdated Show resolved Hide resolved
@MillerAdulu MillerAdulu added this pull request to the merge queue Jul 29, 2024
Merged via the queue into droidconKE:main with commit 60606a0 Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linting problems
2 participants