-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghost sign in #122
Merged
Merged
Ghost sign in #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please don't merge yet when you are done looking. Needs https://github.com/droidconKE/droidconEventsBanckend/pull/41 |
Okay let me have a look |
mboyamike
suggested changes
Aug 30, 2024
mboyamike
approved these changes
Aug 30, 2024
NewtonMutugi
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mboyamike
approved these changes
Aug 30, 2024
mboyamike
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our mobile app only has social sign-in with Google. Google Play requires that you submit working credentials with the app to log in and review the app. Google requires every account to have 2FA setup, so it's unrealistic to hand them your personal account because the 2FA will fail. So this PR is to seed a dummy user on the app which the app can then use in Ghost mode to have the auth be circumvented on the app by long pressing the Fluttercon logo. This way they can log in to review the app and then once the app has been released, on the mobile end, we shall disable review mode so that normal users don't use this as a feature to bypass the login.
Type of Change
Test Changes on Device
You can download your APK from Firebase App Distribution once this PR builds successfully via the following link: https://appdistribution.firebase.dev/i/c796669942f8a811