Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost sign in #122

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Ghost sign in #122

merged 5 commits into from
Aug 30, 2024

Conversation

MillerAdulu
Copy link
Contributor

Description

Our mobile app only has social sign-in with Google. Google Play requires that you submit working credentials with the app to log in and review the app. Google requires every account to have 2FA setup, so it's unrealistic to hand them your personal account because the 2FA will fail. So this PR is to seed a dummy user on the app which the app can then use in Ghost mode to have the auth be circumvented on the app by long pressing the Fluttercon logo. This way they can log in to review the app and then once the app has been released, on the mobile end, we shall disable review mode so that normal users don't use this as a feature to bypass the login.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Test Changes on Device

You can download your APK from Firebase App Distribution once this PR builds successfully via the following link: https://appdistribution.firebase.dev/i/c796669942f8a811

@MillerAdulu
Copy link
Contributor Author

@NewtonMutugi,

Please don't merge yet when you are done looking.

Needs https://github.com/droidconKE/droidconEventsBanckend/pull/41

@NewtonMutugi
Copy link
Contributor

Okay let me have a look

lib/features/auth/ui/sign_in.dart Show resolved Hide resolved
lib/main_production.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@NewtonMutugi NewtonMutugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MillerAdulu MillerAdulu added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 23a217d Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants