Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow issues on small devices #104

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Fix overflow issues on small devices #104

merged 2 commits into from
Aug 22, 2024

Conversation

kevinhectorngetich
Copy link
Contributor

Description

This PR addresses overflow issues that were occurring on small devices when displaying long usernames in the social media buttons and GridViews. The changes involve implementing a Wrap widget to allow the buttons to move to the next line on smaller devices, preventing overflow issues. The button width is also constrained to not exceed 200 pixels, ensuring a balanced and responsive layout across different screen sizes.

Additionally, for GridView builders, the manipulation of the [childAspectRatio] can often be challenging when trying to achieve a specific layout. To streamline this process and maintain a consistent design, I've opted to use mainAxisExtent instead. This approach allows for a more predictable and controlled layout, ensuring that the UI remains consistent across different device sizes.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Test Changes on Device

You can download your APK from Firebase App Distribution once this PR builds successfully via the following link: https://appdistribution.firebase.dev/i/c796669942f8a811

@MillerAdulu MillerAdulu self-requested a review August 22, 2024 05:10
Copy link
Contributor

@MillerAdulu MillerAdulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the app version in pubspec.yaml to 1.12.08+11208

@MillerAdulu MillerAdulu added this pull request to the merge queue Aug 22, 2024
Merged via the queue into droidconKE:main with commit 10e9028 Aug 22, 2024
1 check passed
@kevinhectorngetich kevinhectorngetich deleted the fix/overflow-issues-small-devices branch August 24, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants