-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KMM [Domain] - Add a repository to fetch home information #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibettheophilus
requested review from
chepsi,
wangerekaharun,
michaelbukachi,
jumaallan,
misshannah and
MamboBryan
as code owners
June 6, 2024 08:03
chepsi
reviewed
Jun 6, 2024
shared/domain/src/commonMain/kotlin/com/android254/shared/domain/repos/HomeRepo.kt
Outdated
Show resolved
Hide resolved
chepsi
reviewed
Jun 7, 2024
chepsi
reviewed
Jun 7, 2024
shared/data/src/commonMain/kotlin/com/android254/shared/data/repos/HomeRepoImpl.kt
Outdated
Show resolved
Hide resolved
chepsi
reviewed
Jun 7, 2024
shared/domain/src/commonMain/kotlin/com/android254/shared/domain/models/OrganizingPartners.kt
Outdated
Show resolved
Hide resolved
chepsi
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added a few comments.
kibettheophilus
force-pushed
the
fetch-home-info
branch
from
June 7, 2024 09:54
ae755e1
to
453be5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Please make sure to read the Contribution Guidelines
and check that you understand and have followed it as best as possible Explain what your feature
does in a short paragraph. please check the below boxes
./codeAnalysis.sh
on linux/unix orcodeAnalysys.bat
on windows to make sure all lint/formatting checks have been done.Closes/Fixes Issues
#292
Other testing QA Notes
N/A
Please add a screenshot (if necessary)