Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMM [Domain] - Add a repository to fetch home information #299

Merged
merged 10 commits into from
Jun 7, 2024

Conversation

kibettheophilus
Copy link
Contributor

Scope

Please make sure to read the Contribution Guidelines
and check that you understand and have followed it as best as possible Explain what your feature
does in a short paragraph.
please check the below boxes

  • I have followed the coding conventions
  • I have added/updated necessary tests
  • I have tested the changes added on a physical device
  • I have run ./codeAnalysis.sh on linux/unix or codeAnalysys.bat on windows to make sure all lint/formatting checks have been done.

Closes/Fixes Issues

#292

Other testing QA Notes

N/A

Please add a screenshot (if necessary)

Copy link
Contributor

@chepsi chepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added a few comments.

@kibettheophilus kibettheophilus added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit f26dd09 Jun 7, 2024
1 check passed
@kibettheophilus kibettheophilus deleted the fetch-home-info branch June 7, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants