Skip to content

Commit

Permalink
Ft feedback emojis (#142)
Browse files Browse the repository at this point in the history
* Replace feedback text to match design

* Add smilling face emoji

* Add neutral face emoji

* Add neutral face emoji

* Import bad-face feedback emoji

* Import bad-face feedback emoji

* Add neutral face emoji

* Fixes #136; Rename smiling face emoji

* Add feedback strings resource

* Closes #136; Check strings resource directory

* Closes #136; Add strings from string resource file
  • Loading branch information
josphatmwania authored Jun 27, 2023
1 parent 4afde98 commit bb6ad8c
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,11 @@ fun FeedBackScreen(
modifier = Modifier
.height(40.dp)
.width(40.dp),
painter = painterResource(id = R.drawable.smiling),
painter = painterResource(id = R.drawable.ic_feedback_bad_face),
contentDescription = stringResource(id = R.string.sign_in_label)
)
Text(text = "Okay")
Text(
text = stringResource(R.string.Bad))
}
}
Spacer(modifier = Modifier.width(20.dp))
Expand All @@ -183,10 +184,12 @@ fun FeedBackScreen(
modifier = Modifier
.height(40.dp)
.width(40.dp),
painter = painterResource(id = R.drawable.smiling),
painter = painterResource(id = R.drawable.ic_feedback_neutral_face),
contentDescription = stringResource(id = R.string.sign_in_label)
)
Text(text = "Great")
Text(
text = stringResource(R.string.Okay)
)
}
}
Spacer(modifier = Modifier.width(20.dp))
Expand All @@ -199,10 +202,12 @@ fun FeedBackScreen(
modifier = Modifier
.height(40.dp)
.width(40.dp),
painter = painterResource(id = R.drawable.smiling),
painter = painterResource(id = R.drawable.ic_feedback_smiling_face),
contentDescription = stringResource(id = R.string.sign_in_label)
)
Text(text = "Bad")
Text(
text = stringResource(R.string.Great)
)
}
}
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions presentation/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,9 @@
<string name="session_filter_label_beginner">Beginner</string>
<string name="session_filter_label_intermediate">Intermediate</string>
<string name="session_filter_label_advanced">Advanced</string>
<string name="Bad">Bad</string>
<string name="Okay">Okay</string>
<string name="Great">Great</string>


</resources>

0 comments on commit bb6ad8c

Please sign in to comment.