Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] drop unused whoami path and drop redundant endpoints info #358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbtrystram
Copy link
Member

As far as I can see, the whoami endpoint is not used anymore in the console as it pull the username from the oauth token claim.
In the case where we need to keep it (to use with an access token? Is that a use case ? ) we could move it to /api/console/v1alpha1/user/whoami in order to prevent the clash with the apps managements paths.

@jbtrystram jbtrystram requested a review from ctron November 23, 2022 11:04
@jbtrystram
Copy link
Member Author

/test

@drogue-bot
Copy link

Aye, aye, captain! … Triggered System Test worklow!

@drogue-bot
Copy link

Total Passed Failed Ignored Filtered Duration
148 10 138 0 0 20m 23s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/refactor/drop_whoami

Commit: 699dd200bcd9ba053872df2e2b3d172b1b024b0a
Author: jbtrystram <[email protected]>
Date: Wed, 23 Nov 2022 10:01:30 -0100

    [refactor] drop unused whoami path and drop redundant endpoints info resources

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/3532827059

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2022/11/23/test-run-3532827059.html

1 similar comment
@drogue-bot
Copy link

Total Passed Failed Ignored Filtered Duration
148 10 138 0 0 20m 23s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/refactor/drop_whoami

Commit: 699dd200bcd9ba053872df2e2b3d172b1b024b0a
Author: jbtrystram <[email protected]>
Date: Wed, 23 Nov 2022 10:01:30 -0100

    [refactor] drop unused whoami path and drop redundant endpoints info resources

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/3532827059

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2022/11/23/test-run-3532827059.html

@jbtrystram jbtrystram force-pushed the refactor/drop_whoami branch from 699dd20 to 2193e4d Compare January 31, 2023 15:37
@jbtrystram
Copy link
Member Author

/test

@drogue-bot
Copy link

Aye, aye, captain! … Triggered System Test worklow!

@drogue-bot
Copy link

Total Passed Failed Ignored Filtered Duration
148 10 138 0 0 20m 50s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/refactor/drop_whoami

Commit: 2193e4d6cf9d230e493e6a6948bfd44f667aeaf4
Author: jbtrystram <[email protected]>
Date: Tue, 31 Jan 2023 14:37:22 -0100

    [refactor] drop unused whoami path and drop redundant endpoints info resources

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/4055727686

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2023/01/31/test-run-4055727686.html

1 similar comment
@drogue-bot
Copy link

Total Passed Failed Ignored Filtered Duration
148 10 138 0 0 20m 50s

Git: https://github.com/drogue-iot/drogue-cloud @ refs/heads/refactor/drop_whoami

Commit: 2193e4d6cf9d230e493e6a6948bfd44f667aeaf4
Author: jbtrystram <[email protected]>
Date: Tue, 31 Jan 2023 14:37:22 -0100

    [refactor] drop unused whoami path and drop redundant endpoints info resources

Job: https://github.com/drogue-iot/drogue-cloud-testing/actions/runs/4055727686

Report: https://drogue-iot.github.io/drogue-cloud-testing/test-report/2023/01/31/test-run-4055727686.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants