Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an administration client #8

Merged
merged 5 commits into from
Mar 30, 2022
Merged

add an administration client #8

merged 5 commits into from
Mar 30, 2022

Conversation

jbtrystram
Copy link
Member

built on top of #6

@jbtrystram jbtrystram requested review from ctron and lulf March 29, 2022 14:28
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a great set of refactorings @jbtrystram. Re; the roles I'm not sure if we discussed it earlier, but it looks good to me. Left a few comments in code.

src/tokens/v1/client.rs Outdated Show resolved Hide resolved
src/util/client/mod.rs Outdated Show resolved Hide resolved
@jbtrystram jbtrystram changed the base branch from main to tokens March 30, 2022 10:01
@jbtrystram jbtrystram merged commit d2a52d6 into tokens Mar 30, 2022
@jbtrystram jbtrystram deleted the admin_client branch March 30, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants