Add a field to store the HTTP status in Errors. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbtrystram
force-pushed
the
service_status
branch
2 times, most recently
from
73a8f8b to
94ece86
Compare
Having the status code chucked in the string message made it hard to machine-read it. The only uses of the "message" field where simply copying the code in there. I moved that to the display impl.
jbtrystram
force-pushed
the
service_status
branch
from
94ece86 to
45add3d
Compare
ctron
reviewed
May 25, 2022
ctron
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the status code chucked in the string message made it hard to
machine-read it. The only uses of the "message" field where simply
copying the code in there. I moved that to the display impl.