[feat] add a publish client + some improvement around labels. #12

jbtrystram · 2022-04-01T15:28:43Z

i also added a few helper methods in Device and Applications

src/registry/v1/data/common/labels/mod.rs

ctron

This looks good! I really appreciate the effort in adding tests too 👍

[feat] add a publish client + some improvement around labels.

fb83c9e

jbtrystram requested a review from ctron April 1, 2022 15:28

ctron reviewed Apr 4, 2022

View reviewed changes

src/registry/v1/data/common/labels/mod.rs Show resolved Hide resolved

ctron reviewed Apr 4, 2022

View reviewed changes

src/registry/v1/data/common/labels/mod.rs Outdated Show resolved Hide resolved

jbtrystram added 8 commits April 4, 2022 14:54

[fix] small cleanups

9a4bd40

[fix] add url encoding for user provided elements of URLs. Fixes #11

15ec1ef

[feat] - fix error handling when there is no JSON body

91d5980

Convert HashMap to LabelSelector and improve a bit errror handling

ea13df5

Url were already percent encoded

eb7d07d

Add a couple of helpers method to create devices and app and some tests

6c72e8d

Add a From Vec<AsRef<str>> implementation for labels

a43e50f

fix test for LabelSelector

f39518f

jbtrystram force-pushed the publish branch from c476ebd to f39518f Compare April 7, 2022 10:58

ctron approved these changes Apr 7, 2022

View reviewed changes

jbtrystram merged commit c67ec67 into main Apr 7, 2022

jbtrystram deleted the publish branch April 27, 2022 10:15

Provide feedback