-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pg] AWS Data API fixes #1939
[Pg] AWS Data API fixes #1939
Conversation
Hi @dankochetov @AndriiSherman 👋 What are the next steps to merge these fixes? Do you think there is any change to merge them during the month? |
@hugo082 please sign your commits |
@dankochetov done ✅ |
@dankochetov, any updates? |
@hugo082 yes, I'm testing it myself and making adjustments, hoping to merge in the next few days |
I've pushed this PR with my changes into a separate branch, will continue it in #2119 |
This PR address multiple issues on AWS Data API driver, each via a separate commit.
1. Reconciliation of
AwsDataApiSession
withPgSession
base classThe third parameter of
AwsDataApiSession.prepareQuery
should be the name to stay compatible with the postgres query builder especially the.prepare(name: string)
method. - #1171transactionId
is now the fifth one. Anyway it is used internally only. Note that it is also possible to remove the parameter as we have the value on the session instance properties.name
parameter is ignored (as on neon-http driver & some others)2. Fix the transaction id propagation
If the transaction id is not provided on the query, the session should use the current one, the one stored on the instance.
3. Fix nested transactions
4. Tests fixes
Fix outdated tests (mainly because the returned values doesn't match the type on raw execution).
We probably should update the
AwsDataApiPgQueryResultHKT.type: aws.ExecuteStatementCommandOutput
but i'm not sure what would be the right value. Probably something similar to the neon-serverless versionNeonQueryResultHKT.type: QueryResult<Assume<this['row'], QueryResultRow>>;