-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make HNS check and client instantiation more reliable #478
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #478 +/- ##
======================================
Coverage 94.2% 94.2%
======================================
Files 23 23
Lines 1745 1753 +8
======================================
+ Hits 1645 1653 +8
Misses 100 100
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjbull looks good except for how this is documented in the changelog. I don't need to review again once you address that.
Issues #470 and #476 report problems with credentials being used that cannot determine if HNS is enabled on the storage account.
This fix does two things:
_shared
that is implemented in both libraries (SharedKeyCredentialPolicy
). Other kinds of credentials are properly isolated to a shared underlying library in the Azure SDK codebase.get_account_information
results inResourceNotFound
, which indicates the credential does not have permission to get this metadata, we fall back to trying to see if the root dir in the container exists and hashdi_folder=True
which should only be the case when HNS is enabled.Closes #470