Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty content type for s3 objects #332

Merged
merged 2 commits into from
May 13, 2023

Conversation

georgeboot
Copy link
Contributor

Fixes #331

@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #332 (710c07e) into master (28b2eb5) will decrease coverage by 0.3%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #332     +/-   ##
========================================
- Coverage    94.3%   94.1%   -0.3%     
========================================
  Files          22      22             
  Lines        1466    1466             
========================================
- Hits         1383    1380      -3     
- Misses         83      86      +3     
Impacted Files Coverage Δ
cloudpathlib/s3/s3client.py 92.4% <ø> (-0.8%) ⬇️

... and 1 file with indirect coverage changes

@jayqi jayqi self-requested a review May 13, 2023 18:49
Copy link
Member

@jayqi jayqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jayqi jayqi merged commit 557456e into drivendataorg:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 object does not always have a content type
2 participants