-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up non recursive list_dir for google cloud storage #318
Speed up non recursive list_dir for google cloud storage #318
Conversation
Thanks @vlaminckaxel! Looks like a great speedup here. Let me know if you'll have a chance to tackle the code review comments, it would be great to get this in for our next release in a few days. |
Merging this into a local branch to do code review tweaks and run live server tests. Thanks @vlaminckaxel! |
…cloud storage (#321) * Speed up non recursive list_dir for google cloud storage (#318) * use correct env vars for gs, azure bucket perf tests * speedup non recursive _list_dir for gs * linting * make gs mock compatible with delimiter * linting * Code review changes * revert dirs first --------- Co-authored-by: axel.vlaminck <[email protected]>
@vlaminckaxel this got shipped in |
Works like a charm 👍 |
The non-recursive implementation of list_dir for google cloud was slow.
The issue was already stated in the code that we just filtered out the top-level files and dirs out of al the blobs.
This is fixed by setting the delimiter='/' when listing a directory non-recursive.
Perf results
Before
After