-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fine-grained file cache control options #314
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
========================================
- Coverage 94.2% 94.1% -0.2%
========================================
Files 21 22 +1
Lines 1396 1461 +65
========================================
+ Hits 1316 1375 +59
- Misses 80 86 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Will be a great new feature.
I saw a bunch of typos in the caching notebook—wondering if we should nbautoexport it for PR review purposes.
3c9fe99
to
bac8e73
Compare
Thanks @jayqi! I incorporated all your suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One remaining typo. LGTM otherwise!
Co-authored-by: Jay Qi <[email protected]>
Implements fine-grained controls for file cache clearing.
Best overview is the update to caching.ipynb, which you can see in the docs preview:
https://deploy-preview-314--gallant-agnesi-5f7bb3.netlify.app/caching/#clearing-the-file-cache
Probably worth it to start with reading the docs since we want those to be a clear explanation of the change.
Bonus:
.close()
was called twice, the file would upload twice). This usually resulted in a failure to overwrite because modified times were the same. Fixed to not upload ifclose
has already been called.Closes #10