fix tls config, accept any server name

[awly]

No description provided.

[driskell]

Hi,

Was this intended to be made against the master branch?
The master branch is the original Logstash Forwarder 0.3.1 and contains nothing of my work.
The driskell_master branch is my default branch and contains my work - most of which has been now moved to Log Courier http://github.com/driskell/log-courier

If this is intended, please can you fix the code so that the indentation is 2 spaces and not tabs? It will allow me to see the changes in the diff. At the moment, every indented line shows as changed.

(I do prefer tab for indentation but unfortunately this project uses 2 spaces, so we must follow that to keep github diff working)

Jason

[awly]

Sorry, it was indeed intended for main repo, my mistake.

[driskell]

One change I have noticed is this.

This is something I will not merge as it renders the TLS connection insecure for everyone. It would absolutely have to be a configuration options. However, I'm not sure why this is required since in all use cases I know of the server certificate is always known.

I am aware of a breaking change when building with Go 1.3 though, referred to here:
elastic#205

Is this what you are attempting to resolve?

[awly]

To be honest, i accidentally opened this pull request to your repo, it was intended for my fork only.
In any case, the issue is fixed in main repo, so we can skip this discussion, if you will.

[driskell]

Just for reference here I fixed this in Log Courier
driskell/log-courier#3