"lc-admin help" should always do

[cschug]

I would expect lc-admin help to always print the usage information regardless whether a connection to log-courier can be made or not (actually I would furthermore expect that help prints that info only, not preforming any action).

# /etc/init.d/log-courier start
Starting log-courier:                                      [  OK  ]
# lc-admin help
Log Courier version 0.14 client

Attempting connection to unix:/var/lib/log-courier/admin.sock...
Connected

Available commands:
  reload    Reload configuration
  status    Display the current shipping status
  exit      Exit
# /etc/init.d/log-courier stop
Stopping log-courier:                                      [  OK  ]
# lc-admin help
Log Courier version 0.14 client

Attempting connection to unix:/var/lib/log-courier/admin.sock...
Failed to connect: dial unix /var/lib/log-courier/admin.sock: no such file or directory

[driskell]

Yes I agree.

In my head at the time I was considering sending the help command to the log-courier instance to list the commands. This way even if you upgraded only half the instances - you could use a single version (latest) of lc-admin to connect to any instance (even older version) and see commands available.

There's probably better more intuitive ways to reach that goal though than the current method!

Jason