Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and usage information do not mention the "lc-admin ping" command #49

Closed
cschug opened this issue Sep 23, 2014 · 4 comments

Comments

@cschug
Copy link

cschug commented Sep 23, 2014

While tested with version 0.14, looking at the source the same should be true for the current version 0.15

# lc-admin help
Log Courier version 0.14 client

Attempting connection to unix:/var/lib/log-courier/admin.sock...
Connected

Available commands:
  reload    Reload configuration
  status    Display the current shipping status
  exit      Exit
# lc-admin ping
Log Courier version 0.14 client

Attempting connection to unix:/var/lib/log-courier/admin.sock...
Connected

Pong
@driskell
Copy link
Owner

Thanks for the report.

I'll consider what to do here. Ping was intended as an internal only command that lc-admin would automatically send every 15 mins or so when idle to keep a connection open.

Either I'll add it to the help or make it so it cannot be run manually (so it's restricted to protocol).

Jason

@cschug
Copy link
Author

cschug commented Sep 24, 2014

Ah, I see, thanks for the explanation.

Some question a little bit beyond the scope of this issue, but are there any plans to incorporate some mechanism, which could be useful to monitor the health of the service, especially also the log-courier plugin side for Logstash? In the most basic form I am thinking of a service check for Nagios or Icinga (https://www.monitoring-plugins.org/doc/guidelines.html#PLUGOUTPUT) which just returns the status whether the service can be reached over the network and responses in time. I don't know if it makes sense to create something from scratch as considerable parts of the implementation already do exists here in the project, e.g. certificate handling, configuration file parsing, wire protocol. What do you think?

@driskell
Copy link
Owner

Monitoring the logstash side I will leave to logstash itself. The lc-admin utility though is intended to allow monitoring on the client side, such as number of logs and speed. I was planning to set up a munin graph to show this. If logstash shutdown too you'd be able to check the connection status. If logstash hung possibly check the events transmitted is increasing or not.

lc-admin status is also great when I'm debugging harvesting and such as I can see exactly what log-courier is watching and what state its in.

@driskell
Copy link
Owner

Regarding logstash side though - To be fair I've not seen an instance where checking the log-courier port is working on application layer would throw up an issue. If its not listening, that's easy check for just TCP port, and logstash probably died. For application layer I can't see it throwing anything up, as it would just be a PING. If it's sending an event though and expecting it out into elastic search that would be complex to check. Probably a bit out of scope as you say!

dsmith pushed a commit to tinyspeck/log-courier that referenced this issue Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants