Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sidecar containers #32

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

drinkataco
Copy link
Owner


name: Pull Request
about: Create a pull request to contribute to the Helm chart collection

Description

  1. Support changing servicePort for deployment services
  2. Add support for side car containers
  3. Add instructions for setting up transmission through gluetun. This took me a while to get running properly, so better share

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Non-breaking change which adds functionality
  • Documentation update

Checklist

  • I have updated the chart version in Chart.yaml according to semantic versioning.
  • I have included any new or changed values in the values.yaml file and documented them in the README if applicable.
  • My changes are tested and proven to work.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@drinkataco drinkataco merged commit a911918 into main Oct 8, 2024
2 checks passed
@drinkataco drinkataco deleted the feature/further_customisation branch October 8, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant