Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icon: isActive="false" can lead to wrong css classes #8435

Closed
manucorporat opened this issue Oct 3, 2016 · 1 comment
Closed

icon: isActive="false" can lead to wrong css classes #8435

manucorporat opened this issue Oct 3, 2016 · 1 comment

Comments

@manucorporat
Copy link
Contributor

manucorporat commented Oct 3, 2016 •
edited
Loading

RC0

screen shot 2016-10-03 at 15 34 44

On iOS:
name="md-SOMETHING" isActive="false"
generates:
.md-SOMETHING-outline
which is invalid class.

name="ios-SOMETHING-outline" isActive="false"
generates:
.ios-SOMETHING-outline-outline
which is invalid
@manucorporat
Copy link
Contributor Author

This is probably a duplicate of #6046
But I think we should keep this open, since this issue points to the root cause.

@jgw96 jgw96 mentioned this issue Oct 4, 2016
Closed
manucorporat added a commit to manucorporat/ionic that referenced this issue Oct 6, 2016
@manucorporat
fix(icon): isActive="false" with ios mode
52c16a8 
fixes ionic-team#8435
@manucorporat manucorporat mentioned this issue Oct 6, 2016
Merged
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manucorporat