Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showWhen/hideWhen + [hidden]="" will fail #5836

Closed
SP1966 opened this issue Mar 14, 2016 · 1 comment
Closed

showWhen/hideWhen + [hidden]="" will fail #5836

SP1966 opened this issue Mar 14, 2016 · 1 comment
Assignees
Milestone

Comments

@SP1966
Copy link

SP1966 commented Mar 14, 2016

Short description of the problem:

When showWhen or hideWhen are used in addition to the [hidden]="" directive the component will be displayed even on the platform that it should remain hidden on.

For example, if hideWhen="ios" is used on a FAB button the FAB will not initially display on iOS. But if I add [hidden]="showFAB" to the button and then toggle the showFAB value using a button on iOS the FAB will be shown once the showFAB value is toggled back to true.

What behavior are you expecting?

A component with either showWhen or hideWhen should ignore the [hidden]="" directive so it won't be shown on the wrong platform yet still allows the component to be toggled on the correct platform.

Which Ionic Version? 2.x

@jgw96 jgw96 added the v2 label Mar 17, 2016
@brandyscarney brandyscarney self-assigned this Mar 22, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.5 milestone Mar 22, 2016
brandyscarney added a commit that referenced this issue Apr 15, 2016
Each directive applies a different class so they won’t remove each
other if they’re on the same element. If either class is applied the
element won’t display.

closes #5836
@brandyscarney
Copy link
Member

Thanks for the issue! This will be fixed in the next release 2.0.0-beta.5. 😄

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants