fix(datetime): emit ioncancel event on backdrop click for datetime #10532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent - fix for all picker components instead of specifically for datetime
9 tasks
manucorporat
suggested changes
Apr 1, 2017
src/components/datetime/datetime.ts
Outdated
| @@ -513,7 +513,7 @@ export class DateTime extends Ion implements AfterContentInit, ControlValueAcces | |||
| picker.present(pickerOptions); | |||
|
|
|||
| this._isOpen = true; | |||
| picker.onDidDismiss(() => { | |||
| picker.onDidDismiss((data: any, role: any) => { | |||
There was a problem hiding this comment.
the closure's arguments are not used at all, why this change?
There was a problem hiding this comment.
Sorry, I missed your question. I probably added them for debugging and forgot about them. Thanks for reverting the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
The datepicker component will emit ioncancel event on backdrop click
Changes proposed in this pull request:
If dismiss was received with role backdrop, emit ioncancel
Ionic Version: 1.x / 2.x
2.x
Fixes: #