Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert): add sass variables for checkbox and radio button text color #10331

Merged
merged 6 commits into from
Feb 10, 2017

Conversation

alan-agius4
Copy link
Contributor

Short description of what this resolves:

There is no variable to style alert checkbox and radio button text color. This is essential when changing the background color of the alert.

Changes proposed in this pull request:

  • Add sass variables

Ionic Version: 2
Fixes: #10301

@jgw96 jgw96 added this to the 2.1.0 milestone Feb 9, 2017
@brandyscarney
Copy link
Member

Thanks for the PR! It looks great but can you change it so it is set to initial by default? :)

@alan-agius4
Copy link
Contributor Author

@brandyscarney sure, done :)

@jgw96 jgw96 self-assigned this Feb 10, 2017
@jgw96
Copy link
Contributor

jgw96 commented Feb 10, 2017

@alan-agius4 so it looks like here https://github.com/driftyco/ionic/pull/10331/files#diff-e762eea46251b35026d2565b3d9400baR324 and here https://github.com/driftyco/ionic/pull/10331/files#diff-e762eea46251b35026d2565b3d9400baR381 you are using te wrong variable name. It should be $alert-ios-checkbox-label-text-color. Would you mind giving that a quick fix? Thanks!

@jgw96 jgw96 added the v2 label Feb 10, 2017
@alan-agius4
Copy link
Contributor Author

@jgw96 oops sorry, updated

@jgw96
Copy link
Contributor

jgw96 commented Feb 10, 2017

@alan-agius4 No problem! Thanks for the quick update.

@jgw96
Copy link
Contributor

jgw96 commented Feb 10, 2017

@alan-agius4 Sorry, one more quick thing. There is some trailing whitespace here 1ba020a#diff-63402c347b0956ff4e46ede6251f9690R414 that is causing our sass linter to fail. Mind getting rid of that?

@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Feb 10, 2017 via email

@jgw96 jgw96 merged commit 9cd42dd into ionic-team:master Feb 10, 2017
@jgw96
Copy link
Contributor

jgw96 commented Feb 10, 2017

Thanks for the PR @alan-agius4 !

@TechSnake
Copy link

Hello there ; i am having same problem ,i downloaded ionic 2 one months ago and started to write an app ,i finished an app two days ago with ionic 2 now i updated ionic and my ionic info is

ordova CLI: 6.5.0
Ionic Framework Version: 2.1.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.3
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.4
Xcode version: Not installed

However ,it show white screen when i serve it but there is no error .How can i solve this problem.

Thank you in advance

@TechSnake
Copy link

i wrote my app via ionic-angular": "2.0.1", now i have ionic-angular": "2.1.0" thank you

@TechSnake
Copy link

I have done it thank you SOLVED

@TechSnake
Copy link

I have done it SOLVED thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants