-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alert): add sass variables for checkbox and radio button text color #10331
feat(alert): add sass variables for checkbox and radio button text color #10331
Conversation
Thanks for the PR! It looks great but can you change it so it is set to |
@brandyscarney sure, done :) |
@alan-agius4 so it looks like here https://github.com/driftyco/ionic/pull/10331/files#diff-e762eea46251b35026d2565b3d9400baR324 and here https://github.com/driftyco/ionic/pull/10331/files#diff-e762eea46251b35026d2565b3d9400baR381 you are using te wrong variable name. It should be |
@jgw96 oops sorry, updated |
@alan-agius4 No problem! Thanks for the quick update. |
@alan-agius4 Sorry, one more quick thing. There is some trailing whitespace here 1ba020a#diff-63402c347b0956ff4e46ede6251f9690R414 that is causing our sass linter to fail. Mind getting rid of that? |
updated
…On 10 February 2017 at 18:48, Justin Willis ***@***.***> wrote:
@alan-agius4 <https://github.com/alan-agius4> Sorry, one more quick
thing. There is some trailing whitespace here 1ba020a#diff-
63402c347b0956ff4e46ede6251f9690R414
<1ba020a#diff-63402c347b0956ff4e46ede6251f9690R414>
that is causing our sass linter to fail. Mind getting rid of that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10331 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQv-Wk92OmqMPDRHqNWs99YISNGRUMfrks5rbKLggaJpZM4L4p9N>
.
|
Thanks for the PR @alan-agius4 ! |
Hello there ; i am having same problem ,i downloaded ionic 2 one months ago and started to write an app ,i finished an app two days ago with ionic 2 now i updated ionic and my ionic info is ordova CLI: 6.5.0 However ,it show white screen when i serve it but there is no error .How can i solve this problem. Thank you in advance |
i wrote my app via ionic-angular": "2.0.1", now i have ionic-angular": "2.1.0" thank you |
I have done it thank you SOLVED |
I have done it SOLVED thank you |
Short description of what this resolves:
There is no variable to style alert checkbox and radio button text color. This is essential when changing the background color of the alert.
Changes proposed in this pull request:
Ionic Version: 2
Fixes: #10301