Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No variable for overriding ion-option label text color #10301

Closed
ivanrylov opened this issue Feb 3, 2017 · 2 comments
Closed

No variable for overriding ion-option label text color #10301

ivanrylov opened this issue Feb 3, 2017 · 2 comments
Assignees
Milestone

Comments

@ivanrylov
Copy link

Ionic version: (check one with "x")
[ ] 1.x
[ x] 2.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
For the dark theme, ion-option label text color is #000 (black) and there is no sass variable to override it.
It is possible to override only selected item using $alert-ios-radio-label-text-color-checked which is not enough for the dark theme.

Expected behavior:*
There should be a variable which could be used for overriding ion-option label text color.

Steps to reproduce:

  1. Change the background of the Alert:
$alert-ios-background: #24242d;
$alert-md-background-color: #24242d;
$alert-wp-background: #24242d;
  1. Create simple select with few options.
<ion-select [(ngModel)]="gaming">
      <ion-option value="nes">NES</ion-option>
      <ion-option value="n64">Nintendo64</ion-option>
      <ion-option value="ps">PlayStation</ion-option>
      <ion-option value="genesis">Sega Genesis</ion-option>
      <ion-option value="saturn">Sega Saturn</ion-option>
      <ion-option value="snes">SNES</ion-option>
</ion-select>
  1. Run as a website in browser
  2. Click select and check the options label color which is black.

Other information:
There should be such sass variables available:

$alert-ios-radio-label-text-color;
$alert-md-radio-label-text-color;
$alert-wp-radio-label-text-color;

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

run as a website
Ionic Framework Version: 2.0.0
Ionic App Scripts Version: 1.0.0
@jgw96
Copy link
Contributor

jgw96 commented Feb 10, 2017

Closing this issue as the above PR was merged. Thanks!

@jgw96 jgw96 closed this as completed Feb 10, 2017
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 4, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants