Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

allow building despite TS errors #443

Closed
KiaraGrouwstra opened this issue Nov 20, 2016 · 3 comments
Closed

allow building despite TS errors #443

KiaraGrouwstra opened this issue Nov 20, 2016 · 3 comments

Comments

@KiaraGrouwstra
Copy link
Contributor

Currently app-scripts' TS transpiler cancels the build on TS errors. I definitely like the pretty screen, but enforcing this behavior as a default setting presumes that the typings of all libraries, and in fact, TypeScript itself, are both infallible. I feel this might not be fully realistic in all cases, especially given even just the TypeScript repo itself has around 1.5k outstanding issues. Might it be an option to allow overriding this behavior with e.g. a command-line switch?

Related:

@danbucholtz
Copy link
Contributor

We may someday allow this but this behavior does not jive with what we think provides the best experience. I'll keep it open as a low priority issue.

Thanks,
Dan

@KiaraGrouwstra
Copy link
Contributor Author

In the event you'd nevertheless be willing to take a PR on this, I've made one from my fork.

@danbucholtz
Copy link
Contributor

@tycho01,

Sorry, this is outside of the scope of what we intend to do. Maybe in the future but in all sincerity probably not.

Thanks,
Dan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants