feat: add --ignorets flag to allow building despite TS errors, fixes …

…ionic-team#443
KiaraGrouwstra · Nov 24, 2016 · da21bff · da21bff
1 parent 0821afd
commit da21bff
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/dev-server/serve-config.ts b/src/dev-server/serve-config.ts
@@ -13,6 +13,7 @@ export interface ServeConfig {
   useServerLogs: boolean;
   notifyOnConsoleLog: boolean;
   useProxy: boolean;
+  ignoreTsErrors: boolean;
 }
 export const LOGGER_DIR = '__ion-dev-server';
 export const IONIC_LAB_URL = '/ionic-lab';
diff --git a/src/serve.ts b/src/serve.ts
@@ -31,7 +31,8 @@ export function serve(context?: BuildContext) {
     notificationPort: getNotificationPort(context),
     useServerLogs: useServerLogs(context),
     useProxy: useProxy(context),
-    notifyOnConsoleLog: sendClientConsoleLogs(context)
+    notifyOnConsoleLog: sendClientConsoleLogs(context),
+    ignoreTsErrors: getIgnoreTsErrors(context)
   };
 
   createNotificationServer(config);
@@ -130,3 +131,7 @@ function useProxy(context: BuildContext) {
 function sendClientConsoleLogs(context: BuildContext) {
   return hasConfigValue(context, '--consolelogs', '-c', 'ionic_consolelogs', false);
 }
+
+function getIgnoreTsErrors(context: BuildContext) {
+  return hasConfigValue(context, '--ignorets', '-i', 'ionic_ignore_ts_errors', false);
+}
diff --git a/src/transpile.ts b/src/transpile.ts
@@ -119,7 +119,7 @@ export function transpileWorker(context: BuildContext, workerConfig: TranspileWo
 
     const diagnostics = runTypeScriptDiagnostics(context, tsDiagnostics);
 
-    if (diagnostics.length) {
+    if (diagnostics.length && !context.ignoreTsErrors) {
       // darn, we've got some things wrong, transpile failed :(
       printDiagnostics(context, DiagnosticsType.TypeScript, diagnostics, true, true);
 
@@ -175,7 +175,7 @@ function transpileUpdateWorker(event: string, filePath: string, context: BuildCo
 
     const diagnostics = runTypeScriptDiagnostics(context, transpileOutput.diagnostics);
 
-    if (diagnostics.length) {
+    if (diagnostics.length && !context.ignoreTsErrors) {
       printDiagnostics(context, DiagnosticsType.TypeScript, diagnostics, false, true);
 
       // darn, we've got some errors with this transpiling :(
@@ -328,7 +328,7 @@ export function getTsConfig(context: BuildContext, tsConfigPath?: string): TsCon
 
     const diagnostics = runTypeScriptDiagnostics(context, parsedConfig.errors);
 
-    if (diagnostics.length) {
+    if (diagnostics.length && !context.ignoreTsErrors) {
       printDiagnostics(context, DiagnosticsType.TypeScript, diagnostics, true, true);
       throw new BuildError();
     }