Gmail SMTP support in Postal #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Sam! A few corrections before I can accept it. o Let's leave whitespace changes out of this pull request. Some of yours are valid but I'd like to keep it to the core functional changes. o Move do-when to a postal.support namespace. Maybe make-props should go there too since it only depends on Properties. o Don't change com.draines to paddleguru. o Call the :ssl key :tls. Those are different and we don't want to conflate. I think everything else looks good. Thanks for working on this! -Drew |
…amespace. Fixed paddleguru group, changed back to com. ssl key name changed to tls.
|
I think this last commit fixes all of that. Sorry about the whitespace changes, emacs tends to reformat code that I touch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Drew,
I'm not sure this is the best way to cover gmail support, but I've got it working and wanted to submit it to you for comment.