Remove static state from MP4/QuickTime handlers #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These static fields are not threadsafe and create invalid data in concurrent environments. There may be a better design for this, but for now these new context classes just move shared state to the stack. Fixes #421.
kwhopper
approved these changes
Sep 14, 2019
payton
approved these changes
Sep 14, 2019
|
I ran it over the images and there is no diff. However we don't have very many avi/mov files. I'm pretty sure this fixes the problem correctly. The design could definitely be improved. I just wanted the bug fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These static fields were not threadsafe and create invalid data in concurrent environments.
There may be a better design for this, but for now these new context classes just move shared state to the stack.
Fixes #421.