Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exif GPS directory and descriptor updates #333

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

nagix
Copy link
Collaborator

@nagix nagix commented Mar 28, 2018

GPSDirectory

  • Add TAG_H_POSITIONING_ERROR (0x001F), which was added in the Exif 2.3 specification

GPSDescriptor

  • Add a description for TAG_DOP providing a decimal version of rational numbers
  • Add a description for TAG_SPEED providing a decimal version of rational numbers with unit
  • Add a description for TAG_DEST_LATITUDE providing a DMS representation of rational numbers
  • Add a description for TAG_DEST_LONGITUDE providing a DMS representation of rational numbers
  • Add a description for TAG_DEST_DISTANCE providing a decimal version of rational numbers with unit
  • Add a description for TAG_PROCESSING_METHOD and TAG_AREA_INFORMATION providing a string representation using the character code stored in the first 8 bytes of the byte array
  • Add a description for TAG_H_POSITIONING_ERROR providing a decimal version of rational numbers with unit

@drewnoakes drewnoakes merged commit 1c07926 into drewnoakes:master Mar 28, 2018
@drewnoakes
Copy link
Owner

Fantastic, as always :)

@nagix
Copy link
Collaborator Author

nagix commented Mar 28, 2018

I borrowed text decoding code from ExifDescriptorBase.getUserCommentDescription() to implement a descriptor for TAG_PROCESSING_METHOD and TAG_AREA_INFORMATION, but should we add a new common method in TagDescriptor and make them use it?

@drewnoakes
Copy link
Owner

Yes, that method looks complicated enough that it should be extracted into TagDescriptor and reused.

@nagix
Copy link
Collaborator Author

nagix commented Mar 29, 2018

Ok, I created #334 for that.

@nagix nagix deleted the issue-333 branch March 29, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants