Spanify (3/n) #367
Merged
Spanify (3/n) #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iamcarbon
commented
Jan 21, 2024
iamcarbon
commented
- Updates mutable byte[] data in HuffmanTablesDirectory with statistically initialized data
- Adds and utilizes JpegSegment.Span property to reduce need for AsSpan()
- Uses static JpegSegmentPreambleBytes in DuckyReader
|
@drewnoakes Ready for review / feedback. CI is failing due to an ambiguous xunit method call (resolved in #366) |
drewnoakes
reviewed
Jan 21, 2024
|
|
||
| ICollection<JpegSegmentType> IJpegSegmentMetadataReader.SegmentTypes { get; } = new[] { JpegSegmentType.AppC }; | ||
| ICollection<JpegSegmentType> IJpegSegmentMetadataReader.SegmentTypes { get; } = [JpegSegmentType.AppC]; |
There was a problem hiding this comment.
We should bump these to IReadOnlyCollection. Can be a future PR.
There was a problem hiding this comment.
Annoyingly, HashSet doesn't implement IReadOnlyCollection, which we use in JpegReader.
There was a problem hiding this comment.
Looking at usages of the property, they're all enumerations. So IReadOnlyCollection or IEnumerable are both candidates, and JpegReader would be changed to no longer use HashSet<T>.
drewnoakes
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.