Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example PR of why to delete images created during a pull request #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

drewmullen
Copy link
Owner

@drewmullen drewmullen commented Jan 20, 2020

This is an example PR to showcase the decision to delete images created during a PR. There are other ways to solve this problem. Ideally a 'dry-run' feature would be baked into Packer.

We delete artifacts (images) created by PR CI runs to avoid the 3 C's:

  • Congestion: PRs with multiple commits will publish multiple images
  • Confusion: With all the extra images you will undoubtedly have a hard time knowing which to use and may even use a bad or outdated image
  • Cost: You pay for every image you publish and maintain

Stated plainly, PRs are opportunities to review code before it is added to your master branch. If you consider that artifacts are yielded from the code, the same logic also follows, artifacts outputted from PR CIs should also be used for review opportunity

@drewmullen drewmullen changed the title update Example PR of why to delete images created during a pull request Jan 20, 2020
@sarcasticadmin
Copy link

sarcasticadmin commented Jan 20, 2020

Im glad you remembered to bump the version

@xv-carlos-c
Copy link

I really don't understand why hashicorp is ignoring this request, I remember a couple years ago it was possible I had a boolean value being always true for PRs and and false when the build was from master/main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants