Example PR of why to delete images created during a pull request #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example PR to showcase the decision to delete images created during a PR. There are other ways to solve this problem. Ideally a 'dry-run' feature would be baked into Packer.
We delete artifacts (images) created by PR CI runs to avoid the 3 C's:
Stated plainly, PRs are opportunities to review code before it is added to your master branch. If you consider that artifacts are yielded from the code, the same logic also follows, artifacts outputted from PR CIs should also be used for review opportunity