Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that JDKs newer than 8 use invokedynamic for toString #229

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Test that JDKs newer than 8 use invokedynamic for toString #229

merged 1 commit into from
Sep 6, 2023
+28 −12

Conversation

JakeWharton
Copy link
Collaborator

Just ensuring we don't regress this performance-related optimization by accident.

@drewhamilton
Copy link
Owner

Oh good, so the compiler does optimize in the way I thought it should in this comment?

@JakeWharton
Copy link
Collaborator Author

JakeWharton commented Sep 6, 2023 •
edited
Loading

Yep! It wasn't observable (in our tests) because the root build was resetting the target back to 8 despite using newer JDKs as the toolchain.

@drewhamilton drewhamilton merged commit 937ef64 into drewhamilton:main Sep 6, 2023
5 checks passed
@JakeWharton JakeWharton deleted the jw.invoke-dynamic.2023-09-05 branch September 6, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewhamilton drewhamilton drewhamilton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeWharton @drewhamilton