Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lidl/hg08673 / TS011F - Removed stray ";" that stopped consumption from working #7779

Merged
merged 1 commit into from
May 26, 2024

Conversation

Akulatraxas
Copy link
Contributor

Got a few of these devices and noticed that power was reading fine but consumption was always 0. Noticed a stray ";" in the DDF. After removing it the consumption reading is working.

And maybe a small request: I know this is not the homeassistant Community but i am sure someone can point me to the right place: I noticed that in the output of the REST call for this device is the voltage reading as well. That does not show up in HA. Where in this process is decided what part of the REST output is included in the HA Entitites ?

@manup
Copy link
Member

manup commented May 23, 2024

While the change is fine for cosmetics, it doesn't make any difference for the Javascript execution.

@Akulatraxas
Copy link
Contributor Author

@manup
that might be, but when i add the ; back in consumption reporting of the device stays at 0. at least i can reproduce it by adding it back in for functioning devices.

@Smanar
Copy link
Collaborator

Smanar commented May 23, 2024

Hello,
and you make other thing after the edition ? (that can impact too the result), "hot reload" or restart deconz or re-include.

And you can reproduce the issue every time ?

I don't understand because all my JS code in DDF are using the ";" ........

@manup
Copy link
Member

manup commented May 23, 2024

It's a bit strange yeah, strictly speaking in Javascript the ; shouldn't make any difference.
However maybe the DuktapeJS engine does something fugly here, since this isn't the first PR doing this I'll schedule some tests to see what's going on. (maybe it's a problem with one liners and no newline character at the end, but how knows..)

Copy link
Contributor

Hey @Akulatraxas, thanks for your pull request!

Tip

Modified bundles can be downloaded here.
Relative expire date

DDF Bundles changes

Modified

  • lidl/hg08673.json : HG08673 LIDL SilverCrest smart plug with monitoring (DK, EU, FR) ✔️

Validation

Tip

Everything is fine !

🕝 Updated for commit 870c0be

@manup manup added the Fix label May 26, 2024
@manup manup added this to the v2.27.1-beta milestone May 26, 2024
@manup manup merged commit acd0adc into dresden-elektronik:master May 26, 2024
1 check passed
Copy link
Contributor

This pull request is now merged. The new DDF bundles have been uploaded to the store.

DDF Bundles

Modified

  • lidl/hg08673.json : HG08673 LIDL SilverCrest smart plug with monitoring (DK, EU, FR) : with hash (2da701458b)

🕦 Updated for commit acd0adc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants