Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ikea Rodret group bindings/button events #7757

Merged
merged 1 commit into from
May 13, 2024

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented May 10, 2024

There was a case described on Discord where the dimmer apparently did not fire any button events and there were also no traces of any button presses in the debug log. With the modifications of the DDF and a re-pair of the device, the device was brought to a working state.

Presumably, the added meta item was missing and required to actually make the bindings work. However, this is just a guess, as I'm not fully sure about its importance.

@SwoopX SwoopX added the Fix label May 10, 2024
@SwoopX SwoopX added this to the v2.27.0-beta milestone May 10, 2024
@manup
Copy link
Member

manup commented May 13, 2024

Yeah the DDF group setup/interaction is an odd feature and needs some better documentation.

The best description for meta group.endpoints so far is in:

/*! On reception of an group command, check that the config.group entries are set properly.
- This requires the DDF has { "meta": { "group.endpoints": [<endpoints>] }} set,
or as alternative the DDF has group bindings specified.
- This takes into account if there are also matching bindings set in the DDF.
- "auto" entries are replaced based on the index in group.ednpoints.
- Existing group entries are replaced if the device hasn't configured bindings in the DDF.
*/
void DEV_CheckConfigGroupIndication(Resource *rsub, uint8_t srcEndpoint, uint dstGroup, const DeviceDescription::SubDevice &ddfSubDevice)

@manup manup merged commit 5bcd2c8 into dresden-elektronik:master May 13, 2024
1 check passed
@SwoopX SwoopX deleted the rodret_fix branch May 18, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants