Fix: Make Hue motion sensors configurable again #6091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, could you test this with one of the sensors? |
|
Yeah, I tested it with 1st gen indoor and have it also running with 2nd gen. |
|
Perfect, I'll run the PR tomorrow in my setup and add a few simple rules. |
|
Works fine in my setup 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the sensors were missing the respective write functions to actually trigger the configuration change. On that occasion, the DDFs have been reworked:
config/usertesthas been addedBased on this change, the associated legacy code could be removed.
config/pendingis effectively not used anymore and could be removed as well.