Fix DDF handling of negative values and values above 2^52 #5910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For signed integers the C++ union is tricky as the correct member needs to be extracted. In contrast to unsigned integers num.s16 != num.s64. Since the ZclAttribute already has the correct negative number in its internal QVariant we can just use it. Also expose 56-bit values as string since JS only has 2^52 integers. The scopes where added to prevent stack corruption (not actually reported but to be safe..).
|
Does this also fix the power value -1 for the unisys D1 R? See ebaauw/homebridge-deconz#29 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For signed integers the C++ union is tricky as the correct member needs to be
extracted. In contrast to unsigned integers num.s16 != num.s64. Since the
ZclAttribute already has the correct negative number in its internal QVariant
we can just use it.
Also expose 56-bit values as string since JS only has 2^52 integers.
The scopes where added to prevent stack corruption (not actually reported but to be safe..).