Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDF for Danfoss Ally thermostat #5793

Merged
merged 6 commits into from
Apr 6, 2022
Merged

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented Feb 14, 2022

Relies on #5857

DDF including default parsing functions for scheduler_on, heatsetpoint, valve, locked, lastset, localtime and utc resource items. Furthermore, device specific code has been partially removed. Most config/ resource items now use state changes to write data on the device and devManaged check has been extended to power configuration, thermostat UI and diagnostics cluster. Lastly, as an interim solution, the to check for time drifts on the time cluster had to be moved from updateSensorNode() to handleTimeClusterIndication(), as otherwise a time sync wouldn't be triggered anymore on managed devices.

It should also be applicable for POPP and Hive thermostat if manufacturer name and model ID are changed accordingly

@Smanar
Copy link
Collaborator

Smanar commented Mar 8, 2022

Why the status is still draft ?
You have issue with it ?

@SwoopX
Copy link
Collaborator Author

SwoopX commented Mar 9, 2022

That's relatively simple, because

  • there's currently no (generic) function to trigger repeated cluster specific commands. Relevant for reading on-device schedules
  • there's currently no parsing function which can handle schedules
  • there's currently no parsing function which can handle the time calculations for the respective time resource items
  • there's currently no viable mechanism to evaluate or trigger time synchronisation automatically

😄 Other than that, the DDF works.

@SwoopX SwoopX marked this pull request as ready for review March 23, 2022 23:03
@manup manup added this to the v2.15.1 milestone Apr 6, 2022
@manup manup merged commit 9a43866 into dresden-elektronik:master Apr 6, 2022
@SwoopX SwoopX deleted the ally branch May 29, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants