Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger manufacturer name read and consider it while selecting DDF #5789

Merged
merged 3 commits into from
Feb 26, 2022

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented Feb 14, 2022

See the linked issue for further info.

  • Ensure that the model ID and the manufacturer name are now queried if the values are not yet known.
  • The respective DDF match is now executed on both attributes instead of just the model ID.
  • Additionally, neither the manufacturer name nor the model ID is set to "Unknown" if not queried and respective checks have been removed.

The DDF match might be extended in future to e.g. take a device firmware into account.

Additionally, this includes the successor of #5829 to fix matching the manufacturer name agains constants.

@SwoopX SwoopX marked this pull request as ready for review February 17, 2022 23:22
@SwoopX SwoopX linked an issue Feb 25, 2022 that may be closed by this pull request
@SwoopX SwoopX added this to the v2.15.0-beta milestone Feb 26, 2022
@manup manup merged commit e0eb3ab into dresden-elektronik:master Feb 26, 2022
@SwoopX SwoopX deleted the ddfmanufacturerfix branch March 21, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants