DDF add ubisys S2 #5698
Merged
DDF add ubisys S2 #5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DDF replaces most parts of the C++ implementation. The ubisys S2 was broken since a few releases due code changes. This should also fix the S2-R in legacy code (untestet). Note that the Electrical Measurement cluster doesn't support reporting, and Simple Metering cluster only for attribute 0x0400. The rest gets polled. Like the C4 the button_maps.json was broken due modelid and startsWith() problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DDF replaces most part of the C++ implementation.
The S2 was broken since a few releases due code changes.
Note that the Electrical Measurement cluster doesn't support reporting, and Simple Metering cluster only for attribute 0x0400. The rest gets polled.
Like the C4 the
button_maps.jsonwas broken due incomplete modelid in combination with startsWith() check.