Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of ZCL Default Response #5009

Merged
merged 3 commits into from
Jun 13, 2021
Merged

Fix handling of ZCL Default Response #5009

merged 3 commits into from
Jun 13, 2021

Commits on Jun 13, 2021

  1. Fix handling of ZCL Default Response 

    This PR adds automatic handling of ZCL Default Response to also catch cases where we currently miss sending the response.

The magic happens by observing outgoing APS requests if they contain a specific ZCL response and automatically send the ZCL Default Response at the end of the APS indication processing. For this C++ RAII is used with an extra ZclDefaultResponder object which sends the response in its destructor.

All manual sending of ZCL Default Responses was removed.
    @manup
    manup committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    e7de939 View commit details
    Browse the repository at this point in the history

  2. ZclDefaultResponder ignore OTA commands 

    The OTA plugin is responsible to handle these.
    @manup
    manup committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    19e1619 View commit details
    Browse the repository at this point in the history

  3. ZclDefaultResponder fix indentation and comment typos

    @manup
    manup committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    8dde28c View commit details
    Browse the repository at this point in the history