Fix: Consider ZCL frame control direction for sending default response #4947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why the extra parameter, does it differ from the direction value in |
|
No sure if I get what you mean. However, discussing this, you can probably just revert the direction without the parameter... |
|
Perfect, I think this should do the trick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current code, deCONZ sends default responses, regardless if the come from a client or server cluster of the device with direction Client to Server. While this is appropriate in most cases as the majority of data from devices originates from a server cluster, it fails in case origin is a client cluster.
Consequence is that a default response is sent, but not appropriately understood by the receiving device. This basically has the same effect as if no default response has been sent and can result in duplicate transmissions from the originating device.