Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Door lock database modifications #4795

Merged

Conversation

burken-
Copy link
Contributor

@burken- burken- commented Apr 22, 2021

Added generic and manufacturer specific attributes and commands as specified in the ID Lock 150 Zigbee specification. Information about the generic attributes and methods fetched from the Zigbee cluster library

@burken-
Copy link
Contributor Author

burken- commented Apr 22, 2021

I noticed that "general.xml" had a mix of tabs and spaces. I can normalize this and commit if someone can tell me which would be preferred indentation in this repo.

@Smanar
Copy link
Collaborator

Smanar commented Apr 23, 2021

Ha nice, realy usefull.
So now you can set and get PIN using the GUI ? Can you show a capture with valid value as exemple ?

I will try to use the same command to make same using the API.

@burken-
Copy link
Contributor Author

burken- commented Apr 23, 2021

Yes, Get, Set, Clear PIN are possible from the GUI (only tested with ID Lock 150). Would be awesome if it could be made available through the API as well! What kind of captures do you need, I'm happy to oblige?

Would also be neat if the "Door state" 0x0003 (opened/closed) -attribute could also be exposed in the API, similar as "Lock state" 0x0000.

For Get, Set & Clear-commands

User ID (uint16) = 0 - [# of PIN Users Supported attribute - 0x0012]

For Set pin

User status (uint8) = Only the values 1 (Occupied/Enabled) and 3 (Occupied/Disabled) are allowed for User Status.
User type (enum8) =

  • 0 Unrestricted User (default)
  • 1 Year Day Schedule User
  • 2 Week Day Schedule User
  • 3 Master User
  • 4 Non Access User
  • 0xff Not Supported

PIN (octstr) = Length between "Min PIN Length" (0x0017) and "Max PIN Length" (0x0018)-attributes of the door lock cluster (0x0101)

For Get PIN Response

Same parameters and rules apply as for "Set PIN" apart from User Status
User status (uint8) =

  • 0 Available
  • 1 Occupied / Enabled
  • 3 Occupied / Disabled
  • 0xff Not Supported

@Smanar
Copy link
Collaborator

Smanar commented Apr 23, 2021

Are you able to compile code to test ?
I have added the 0x0003 attribute, and need your help to check something before continuing PIN management.

#3750 (comment)

If you can test the door state and give me logs when you use the "get pin" command using the GUI ?

@burken-
Copy link
Contributor Author

burken- commented Apr 23, 2021

I'll try to compile your branch and check the state as well as the logs from Get PIN-command. Which log topics do you want/need activated to get needed information?

@manup manup added this to the v2.11.2-beta milestone Apr 23, 2021
@Smanar
Copy link
Collaborator

Smanar commented Apr 23, 2021

Better to continue the discution on the issue to not pollute your PR.
But I need log starting by "Door lock", visible with "info"

@manup
Copy link
Member

manup commented Apr 30, 2021

Hi, is the PR ready to merge or work in progress?

@Smanar
Copy link
Collaborator

Smanar commented Apr 30, 2021

I think the @burken- PR is finished ?
The future one for doorlock will be a new one.

@manup manup merged commit d6ea80d into dresden-elektronik:master Apr 30, 2021
@Smanar Smanar mentioned this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants