Add support for SLC S57003 4 channel remote switch, issue #4544 #4711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for SLC S57003, see issue #4544
|
Thanks for the PR. Code looks fine but please check the code style, is there mixed tabs/spaces? (we use only spaces) |
|
Just had a look real quick an besides the already mentionen identation, I feel one or two places where some additions need to be made are missing. Will later have a look in more detail. EDIT: Should be ok now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLC S57003 is produced by Sunricher, identical to Namron 4512703 and others.
See issue #4544, device request "SLC SmartOne S57003 - Wall 4xMono"