FIX, Better Tuya reconization #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2021
Closed
This was referenced Mar 25, 2021
manup
approved these changes
Mar 27, 2021
| @@ -551,13 +551,15 @@ const QString R_GetProductId(Resource *resource) | |||
| } | |||
|
|
|||
| const auto *manufacturerName = resource->item(RAttrManufacturerName); | |||
| const auto *modelId = resource->item(RAttrManufacturerName); | |||
| const auto *modelId = resource->item(RAttrModelId); | |||
This was referenced Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make 2 things, It creates a battery sensor for some tuya covring, and can help for pairing because the sensor can be used to get the manufacture name for the "light" device creation.
It help too for checks, previously I was using
And now
But the problem is R_GetProductId need manufacture name AND model id, but with this modification, only the manufacture name is usefull.