-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API config "externalsensortemp" for Danfoss Ally thermostat #4408
Add API config "externalsensortemp" for Danfoss Ally thermostat #4408
Conversation
@hanskroner this is great! Would you mind adding a few other stuff for Ally? |
@luka6000 What you request is already there, even since day 1 if I recall correctly @hanskroner Nice one 👍 Haven't pushed this one out yet here from my local repo since I wanted to avoid too many merge conflicts :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the minor remarks.
c330849
to
e9405f5
Compare
@SwoopX, thanks for having a look at this! I've implemented the suggestions and updated the PR. |
e9405f5
to
10e08ca
Compare
This looks to be already implemented
The REST API already exposes the current state of the "Window Open detection" feature but doesn't yet allow hinting to the TRV that a window is open, which is what It might make sense to also add support for |
10e08ca
to
27b6602
Compare
Allows for setting an externally-measured temperature value via the REST API. Useful for those of us who have radiators under desks or covered by radiator covers.
27b6602
to
81937be
Compare
I had missed a couple of renames. The branch still built properly, but didn't work 😞 I've made additional changes, and it's both building and working properly now. |
Great work @hanskroner Thanks :)! |
Thanks so much for this patch! As I understand it, this requires the 1.08 firmware. It took ~8 hours for me to upgrade, so I let it run overnight and this morning it was done. :-) |
hello, I have entered the temperature value from an external sensor, but to enable the detection of the external ambient probe what should I do? should I just put the value in / config / externalsensortemp? thank you GoogleTranslate |
I didn't have to do anything other than putting a value in At least for me, the TRVs don't seem to go exclusively after the value reported by the external sensor, but try to get to some middle ground between the externally reported temperature and the internally measured one. |
ok thanks now check with a refresh of 30 min. Google Td |
Allows for setting an externally-measured temperature value via the REST
API. Useful for those of us who have radiators under desks or covered by
radiator covers.