Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API config "externalsensortemp" for Danfoss Ally thermostat #4408

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

hanskroner
Copy link
Contributor

Allows for setting an externally-measured temperature value via the REST
API. Useful for those of us who have radiators under desks or covered by
radiator covers.

@luka6000
Copy link

@hanskroner this is great! Would you mind adding a few other stuff for Ally?
On same cluster
0x0025 Thermostat programming operation mode
0x4003 External Open Window Detected
I think those 2 are also very usefull.
And maybe
0x0001 KeypadLockout
on cluster (0x0204) Thermostat UI Configuration
That would make this trv a great option with deconz

@SwoopX
Copy link
Collaborator

SwoopX commented Feb 12, 2021

@luka6000 What you request is already there, even since day 1 if I recall correctly

@hanskroner Nice one 👍 Haven't pushed this one out yet here from my local repo since I wanted to avoid too many merge conflicts :P

Copy link
Collaborator

@SwoopX SwoopX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the minor remarks.

rest_sensors.cpp Outdated Show resolved Hide resolved
resource.cpp Outdated Show resolved Hide resolved
resource.h Outdated Show resolved Hide resolved
resource.cpp Outdated Show resolved Hide resolved
@hanskroner
Copy link
Contributor Author

@SwoopX, thanks for having a look at this! I've implemented the suggestions and updated the PR.

@hanskroner hanskroner changed the title Added API state "ext_sensortemperature" for Danfoss Ally thermostat Added API state "externalsensortemp" for Danfoss Ally thermostat Feb 13, 2021
@hanskroner hanskroner changed the title Added API state "externalsensortemp" for Danfoss Ally thermostat Added API config "externalsensortemp" for Danfoss Ally thermostat Feb 13, 2021
@hanskroner
Copy link
Contributor Author

0x0025 Thermostat programming operation mode

This looks to be already implemented

0x4003 External Open Window Detected

The REST API already exposes the current state of the "Window Open detection" feature but doesn't yet allow hinting to the TRV that a window is open, which is what 0x4003 seems to be for. Implementing support for this should be straightforward, just need to be careful to not mess up the Eurotronic Spirits, who use 0x4003 for some sort of setpoint reporting.

It might make sense to also add support for 0x4051 which is used to enable/disable the "Window Open detection" feature. I'll try to get both together in a separate PR.

@hanskroner hanskroner changed the title Added API config "externalsensortemp" for Danfoss Ally thermostat Add API config "externalsensortemp" for Danfoss Ally thermostat Feb 14, 2021
Allows for setting an externally-measured temperature value via the REST
API. Useful for those of us who have radiators under desks or covered by
radiator covers.
@hanskroner
Copy link
Contributor Author

I had missed a couple of renames. The branch still built properly, but didn't work 😞 I've made additional changes, and it's both building and working properly now.

@Mimiix
Copy link
Collaborator

Mimiix commented Feb 15, 2021

Great work @hanskroner Thanks :)!

@manup manup merged commit c935159 into dresden-elektronik:master Feb 15, 2021
@manup manup added this to the v2.10.0-beta milestone Feb 15, 2021
@tkintscher
Copy link
Contributor

Thanks so much for this patch!

As I understand it, this requires the 1.08 firmware.
I can confirm that the firmware can be upgraded to 1.08 using the OTA tool in deCONZ, with the firmware file from the manufacturer (https://www.danfoss.com/en/products/smart-heating/dhs/smart-heating/danfoss-ally/danfoss-ally-support/#tab-software, download the zip, then use the ...ota file inside).

It took ~8 hours for me to upgrade, so I let it run overnight and this morning it was done. :-)

@simoneras
Copy link

hello, I have entered the temperature value from an external sensor, but to enable the detection of the external ambient probe what should I do? should I just put the value in / config / externalsensortemp?

thank you

GoogleTranslate

@hanskroner
Copy link
Contributor Author

hello, I have entered the temperature value from an external sensor, but to enable the detection of the external ambient probe what should I do? should I just put the value in / config / externalsensortemp?

thank you

I didn't have to do anything other than putting a value in /config/externalsensortemp. It seems that as long as the value in there is different from -8000, the TRVs take the measurement into account. The Danfoss documentation suggests not writing a value more often than every 30 minutes, and at least once every 3 hours.

At least for me, the TRVs don't seem to go exclusively after the value reported by the external sensor, but try to get to some middle ground between the externally reported temperature and the internally measured one.

@simoneras
Copy link

simoneras commented Feb 17, 2021

ok thanks now check with a refresh of 30 min.
I would like to be able to change the value of PI Heating Demand, do you think it can be done?

Google Td

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants