Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle Mouse Close Option #516

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

fediaFedia
Copy link

@fediaFedia fediaFedia commented Feb 1, 2023

Fantastic software! Can't believe I only now discovered it...
I do remember all the buzz around CairoShell back in 2007 hehe

Been using 7TaskbarTweaker before and it has this amazing feature to remap a middleclick to close a running app... kind of how you middle click to close Browser tabs.

I figured I'd build it for myself, but I saw an issue where someone also asked for it: #513

Might be a very popular and handy feature, hope this PR is good enough :)
By default, it's False

P.S. Went through the trouble to add the languages also...

rrDdmdyXtd

@xoascf
Copy link
Collaborator

xoascf commented Feb 1, 2023

Instead of just making it toggleable between two options, I think it would be better to make three selectable behavior options for the middle click button for tasks, something like:

  • Close window
  • Open new instance
  • Do nothing

Or maybe this could be implemented for later...

Another thing to keep in mind is that this project uses spaces, not tabs, so it's preferable to change that to keep the code formatting consistent.

@xoascf
Copy link
Collaborator

xoascf commented Feb 1, 2023

I've seen some inconsistencies in the translations, I appreciate the work, but it's preferable to limit the PR to just adding this feature and adding the strings to the English version, if possible the translators will take care of updating them as they have been doing so far.

Thank you!

@xoascf xoascf linked an issue Feb 1, 2023 that may be closed by this pull request
@fediaFedia
Copy link
Author

Ok, good to know the translators can do this.
I removed all variations of it except for English.

I wouldn't do it as a "three-selectable" because the "Do Nothing" option seems like it wouldn't be very valuable to have, I think users can already do nothing by not middle clicking it. Besides, would be an extra click to set it up.

@fediaFedia
Copy link
Author

I've seen some inconsistencies in the translations, I appreciate the work, but it's preferable to limit the PR to just adding this feature and adding the strings to the English version, if possible the translators will take care of updating them as they have been doing so far.

Thank you!

Sorry about that, seems like I am unable to commit any whitespace changes

@xoascf
Copy link
Collaborator

xoascf commented Feb 1, 2023

The Do Nothing option was mainly because that was the default behavior in previous versions of Windows, the issue would be if the user does not want it to do nothing as they may press that button by mistake.

@xoascf
Copy link
Collaborator

xoascf commented Feb 1, 2023

Well, the only blank space left and those options maybe (or maybe not) we will add them later, for now this seems to be fine. Thanks!

@fediaFedia
Copy link
Author

Fair point, we are aiming for a trifecta of realism, utility and non-feature-creeping :)
For me personally just the middle clicking alone makes this utility so much more valuable, and I think anyone coming from 7TT will be pleasantly surprised to have it included :)

Thanks for your time

@xoascf xoascf merged commit ec6f531 into dremin:master Feb 1, 2023
@dremin
Copy link
Owner

dremin commented Feb 2, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Middle click to close taskbar item
3 participants