-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametric page name and other changes (v2) #102
Conversation
* @input@ placeholder can be used to reference the given input (useful to create a new namespace) makes #70 obsolete * new ? syntax to overwrite config options from the syntax (defaults still come from the config setting) * support for strftime placeholders in the namespace config. Allows to create a daily page for example * New option autopage which hides the input field. Together with the new date placeholder this allows to create a daily page on a single button click
Options are not used after the handler step, so no need to assign them to the class member.
This should also catch copy'n'paste actions. https://caniuse.com/#feat=input-event
# Conflicts: # syntax.php
# Conflicts: # syntax.php
# Conflicts: # syntax.php
# Conflicts: # syntax.php
# Conflicts: # syntax.php
In commit 22d9c07
The regex for newpagetemplate parameters parsing that was implemented in commit 0d90564 included the leading `#` in the newpagevars parameter, preventing the newpagetemplate plugin from processing the first parameter as `#@param@` would not match the expected `@PARAM@`. Adapting the regex accordingly.
# Conflicts: # plugin.info.txt # syntax.php
Hello, Firstly many thanks to everyone - DW creators & core team as well as this plugin's authors - I'm not a programmer but manage to follow instructions well enough to meet my simple needs. For a few years I've been using add-new-page for every entry I create and love it.
Do I need to do something else to should use the 7id2fib commit mentioned above please. If so then please can someone describe how I apply it please? If not then any other ideas how I can troubleshoot or fix the behaviour please? |
Actually it does not. If it did, this pull request would not be open, it would have a merged status. You can also see that in the network graph, which shows that this PR's branch (pr72) has not been merged into the master branch, the tip of which is release 2024-09-14. As explained in the PR's description above, the reason I did not merge it, is because I did not have time to properly test this code (as I don't use this functionality myself), and I was hoping to get feedback from the community but that has yet to come
The easiest way is to manually install the code from this PR (download it from https://github.com/dregad/dokuwiki-plugin-addnewpage/archive/refs/heads/pr72.zip) instead of using the Extension Manager. It would be great if you could perform some tests and confirm if everything is working as expected. |
Dear @dregad, monsieur EDIT: attempt 1a - core functionality
attempt 1b - core functionality
attempt 2
attempt 3
attempt 4
attempt 5
These 4 attempts had the same behaviour when I omitted the
|
@Whyglobaleyes @WetenSchaap @bhartshorn @Chris75forumname @Hirschii @cblte @Fabien4941 @jonathanwgebb @gnoownow10 @stvoigt |
I installed using the Extension Manager by pointing to the zip file for the PR. I'm working on testing now, but I apparently deleted the original config which wasn't working. Give me a bit to restore the syntax I was using and try it out, I'll report back. |
I did not test extensively, but the strftime and autopage override feature both seem to be functioning. I didn't notice any bugs but will keep an eye out and update you if I notice anything. |
@bhartshorn many thanks for taking the time to test |
yep exactly1 |
Hi, As other have mentioned, strftime and autopage features work well, I tried a few random variations (also with subnamespaces and stuff), and Dokuwiki did what I expected it to do. What did not work is combining the parametric names with pagetemplates:
will use the correct templates, but place the new page in |
Thanks for testing @WetenSchaap
Is this the actual, exact markup ? If so can you please try with |
Oops, yes, made a typo there. Sorry! Don't know why the @ got lost. With the correct syntax, everything works as expected. |
Brilliant, @dregad Many thanks for finishing and finalising the features. Makes my DW a whole lot more comfortable and I'm sure it'll be enjoyed by many other people to o. bw |
@WetenSchaap many thanks for your sponsorship ❤️ ! I must say, that was a very unexpected and pleasant surprise, the first time in so many years of open-source contributions and support that this actually happens. I'll drink a 🍺 to your health ! @Whyglobaleyes thanks for the feedback. |
This is @splitbrain's original contribution (see PR #72), with merge conflicts resolved and some additional code cleanup and fixes, including French translation.
I did that many months ago, and never managed to finalize the testing due to lack of time.
Feedback and testing is welcome.