-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): authorization frontend #404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good but could not test it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't let it run with docker but if I change presenter/server/index.ts
to default port 3001 then I test it with:
- cd authentik && docker compose up
- cd frontend && npm run dev || prod
- cd presenter && npm run dev || prod
The logic works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should require correct values for this - maybe we want so set a default here, since the frontend only makes sense to operate when authentication is possible.
Furthermore the default values for
AUTHORITY: (import.meta.env.PUBLIC_ENV__AUTH__AUTHORITY ?? '') as string,
AUTHORITY_SIGNUP_URI: (import.meta.env.PUBLIC_ENV__AUTH__AUTHORITY_SIGNUP_URI ?? '') as string,
make no sense anymore, since the presenter hides its buttons, not the frontend
Furthermore AUTHORITY_SIGNUP_URI
is not needed in the frontend.
Co-authored-by: Hannes Heine <[email protected]>
Fixed - I kept the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still doesn't work in production.
While I can see it working in dev, I don't get it to work on production.
Running on dev I can see the redirect happening on console and browser.
npm install
npm run dev
In production nothing happens neither on console nor in the the browser
npm install
npm build
npm run server:prod
Looks like a build problem to me. The guard does not trigger at all all when building for production. If I remove all the code and just leave a console, no output is seen anywhere |
🍰 Pullrequest
Based on #403
Issues
Todo