Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presenter): design fixes #178

Merged
merged 18 commits into from
Jan 18, 2024
Merged

fix(presenter): design fixes #178

merged 18 commits into from
Jan 18, 2024

Conversation

maeckes1
Copy link
Contributor

@maeckes1 maeckes1 commented Jan 16, 2024

🍰 Pullrequest

Fixes design and layout bugs.

Issues

Todo

@maeckes1 maeckes1 added bug Something isn't working design service:presenter labels Jan 16, 2024
@maeckes1 maeckes1 self-assigned this Jan 16, 2024
@maeckes1 maeckes1 changed the title fix(presenter): WIP design fixes fix(presenter): design fixes Jan 16, 2024
presenter/src/layouts/DefaultLayout.vue Outdated Show resolved Hide resolved
presenter/src/locales/de.json Outdated Show resolved Hide resolved
presenter/src/locales/de.json Outdated Show resolved Hide resolved
presenter/src/locales/de.json Outdated Show resolved Hide resolved
@ulfgebhardt
Copy link
Member

image
image
Singular Plural

@ulfgebhardt
Copy link
Member

ulfgebhardt commented Jan 17, 2024

Line-Height Mobile top:
image

Desktop mäh (Breakpoint 1185px):
image

@ulfgebhardt
Copy link
Member

There is a hydration error regarding z-index, which might be fixable:
image

Server: z-index:1006;
Client: z-index:1004;

@maeckes1
Copy link
Contributor Author

There is a hydration error regarding z-index, which might be fixable: image

Server: z-index:1006; Client: z-index:1004;

i'll have a closer look again tomorrow. but could be a possible vuetify bug?

see: vuetifyjs/vuetify#19002

@maeckes1 maeckes1 merged commit 88e6bd3 into master Jan 18, 2024
22 checks passed
@ulfgebhardt ulfgebhardt deleted the 129-design-fixes branch February 7, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design service:presenter
Projects
Status: ✅ Done
2 participants