refactor(docker): wrong port numbers #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
force-pushed
the
docs-wrong-port-in-readme
branch
from
352af5f to
8ef481a
Compare
roschaefer
force-pushed
the
docs-wrong-port-in-readme
branch
from
8ef481a to
995ff3d
Compare
roschaefer
changed the title
roschaefer
force-pushed
the
docs-wrong-port-in-readme
branch
from
995ff3d to
855265c
Compare
Elweyn
reviewed
Jun 12, 2024
There was a problem hiding this comment.
@roschaefer
This should be as we have it, cause else we should also change the authentik flows to link to localhost:3000 => localhost:3001 and localhost:3001 => localhost:3000 instead.
On the localhost we want it like this and on stage or live we have them runing on different sub-domains.
1 task
Motivation ---------- Because changing the port numbers would have a side effects on our deployment, I will just fix the typo in the `README.md`. How to test ----------- 1. Compare the README with the `docker-compose.yml`
roschaefer
force-pushed
the
docs-wrong-port-in-readme
branch
from
855265c to
1686bf0
Compare
|
@Elweyn I fixed the typo in the README instead, could you give it another review? |
Elweyn
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Because changing the port numbers would have a side effects on our
deployment, I will just fix the typo in the
README.md.How to test
docker-compose.yml