Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(data-validation): data validation validator #4141

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 23, 2024

  1. Simplify sheet validator
  2. add offsetFormulaByRanges
  3. support developer to register their custom validator

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 23, 2024

Playwright test results

failed  1 failed
passed  19 passed

Details

stats  20 tests across 9 suites
duration  5 minutes, 47 seconds
commit  a489c7c
info  For more information, see full report

Failed tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 118 lines in your changes missing coverage. Please review.

Project coverage is 33.78%. Comparing base (798e1fd) to head (a489c7c).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...a-validation/src/validators/base-data-validator.ts 0.00% 49 Missing ⚠️
...s/sheets-data-validation/src/models/rule-matrix.ts 0.00% 17 Missing ⚠️
...s-data-validation/src/services/dv-cache.service.ts 0.00% 11 Missing ⚠️
...s-data-validation/src/validators/list-validator.ts 0.00% 7 Missing ⚠️
...src/controllers/dv-formula-ref-range.controller.ts 0.00% 3 Missing ⚠️
...idation/src/controllers/dv-ref-range.controller.ts 0.00% 3 Missing ⚠️
...lidation/src/services/dv-custom-formula.service.ts 0.00% 3 Missing ⚠️
...data-validation/src/services/dv-formula.service.ts 0.00% 3 Missing ⚠️
...ckages/sheets-data-validation/src/utils/formula.ts 0.00% 3 Missing ⚠️
...validation/src/validators/text-length-validator.ts 0.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4141      +/-   ##
==========================================
+ Coverage   33.74%   33.78%   +0.04%     
==========================================
  Files        2457     2457              
  Lines      127861   127693     -168     
  Branches    28631    28597      -34     
==========================================
  Hits        43141    43141              
+ Misses      84720    84552     -168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant